Skip to content
jsworkbench.
Learning path
Advanced18 min

Giving and receiving review

Understand the idea

Peer comments help first. The teacher's review is what gates merge on the shared starter.

The idea

Review has two layers on the Team Simulation path:

  1. Peer review — classmates leave comments on the pull request (git review "…"). Comments are encouraged before the teacher looks. They do not block merge by themselves.
  2. Teacher review — the target owner (your teacher) uses the Maintainer Queue to comment, request changes, approve, or merge. Requesting changes sets status to changes_requested and blocks merge until you push a follow-up commit on the source branch (status returns to open).

git review appends a comment on the latest that involves the repository you have open. Use git review --request-changes "…" only when you mean to block merge until the author updates.

What changes

A peer comment is stored on the request; status stays open. A teacher request-changes flips status to changes_requested. The does not move until the author commits. A follow-up commit on the fork updates the diff and, if status was changes_requested, reopens the request to open.

Two layers of review
LayerWhoEffect on merge
Peer commentClassmates on the threadNone — advice only
Request changesUsually the teacher (target owner)Blocks merge until a new source commit reopens the PR
Approve or mergeTarget owner onlyApprove records readiness; merge lands commits on the shared starter

The command

Open the pull request toward the shared starter first. Run git review "Please say who the notes are for" as a peer-style comment. Then edit the file and commit the response on the source branch. The comment stays. The diff moves.

The mistake

Check your graph

The review lives on the pull request. The response, if you committed it, is a new node on the source branch.

Your repository

Leave a peer comment on a pull request aimed at the shared starter, then answer review with a commit.

  1. Step 1

    Peer comment

    Leave a classmate-style comment. This does not block merge. The teacher’s request-changes / approve / merge actions are what gate landing on the shared starter.

  2. Step 2

    Update the file

    In the editor, set the README line to: Notes from my fork, for the class.

  3. Step 3

    Commit the response

    Run git add README.md first. If status was changes_requested, this commit reopens the pull request to open.

The editor edits the working tree. Start a repository and the files appear here.

Follow the steps. Each command step can be placed in the terminal. Edit files in the editor, then stage them.
Supported command reference
  • init
  • add <path> | add .
  • commit -m "message" | commit --amend -m "message"
  • status
  • diff | diff --staged
  • log | log --oneline | log --graph | log --oneline --graph
  • show [ref]
  • branch | branch <name> | branch -d <name>
  • checkout <ref> | checkout -b <name> | switch <name> | switch -c <name>
  • merge <branch>
  • rebase <branch> | rebase -i <branch> | rebase --edit-todo <pick|drop|reword> <hash> [message] | rebase --continue | rebase --abort
  • cherry-pick <ref>
  • reset --soft <ref> | reset --mixed <ref> | reset --hard <ref>
  • revert <ref>
  • stash | stash list | stash pop | stash apply
  • restore <path> | restore --staged <path>
  • remote | remote add <name> <repo-slug>
  • clone <repo-slug> | git clone <repo-slug> | git fork <repo-slug>
  • fetch [remote] | pull [remote] [branch] | push [remote] [branch] | push --force [remote] [branch]
  • blame <path>
  • reflog
  • tag | tag <name> [ref] | tag -d <name>
  • bisect start | bisect good [ref] | bisect bad [ref] | bisect reset
  • config <key> <value> | config --list
  • write <path> <text> (workbench: edit the working tree)
  • issue new "title" | pr new <source> <target> "title" | review "comment" | review --request-changes "comment"

Commit graph

No commits yet. git init creates the first one.

Quiz

A quick check for understanding. Retry as often as you like; your learning path stays open.

01Who can write a review on a cross-repo request?
02What gates merge on the shared starter?

Ready to call this one understood?

Mark this lesson complete to earn 200 XP. You can always revisit it.

Sign in to save progress
Next lesson